Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Asset Downtime on assets lists page #6952

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Show Asset Downtime on assets lists page #6952

merged 7 commits into from
Feb 12, 2024

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Dec 30, 2023 •
edited
Loading

Proposed Changes

Backend PR: #1794
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner December 30, 2023 11:41
@vercel Vercel
Copy link

vercel bot commented Dec 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:15pm

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 57926fe
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65ae864e59eb840008c81465
😎 Deploy Preview https://deploy-preview-6952--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Dec 31, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right way to do it. The asset list page now fetches paginated assets in one call, and paginated availability records in another call.

This does not ensure that you have the availability records of all the assets of the current assets in view.

I think the solution is to add a serializer-level field in the asset list API's serializer that says whether it is down or not.

cc: @Ashesh3

@rithviknishad
Copy link
Member

Also, some other icon would be better. A setting cog icon does not suit for indicating downtime.

@Ashesh3
Copy link
Member

Ashesh3 commented Dec 31, 2023

I don't think this is the right way to do it. The asset list page now fetches paginated assets in one call, and paginated availability records in another call.

This does not ensure that you have the availability records of all the assets of the current assets in view.

I think the solution is to add a serializer-level field in the asset list API's serializer that says whether it is down or not.

cc: @Ashesh3

I agree with you here.

I think the solution is to add a serializer-level field in the asset list API's serializer that says whether it is down or not.

^ this is the ideal solution

@rithviknishad rithviknishad mentioned this pull request Jan 4, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 4, 2024
@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Jan 7, 2024 •
edited
Loading

@rithviknishad is this icon ok?

image

@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Jan 7, 2024
@nihal467
Copy link
Member

@Pranshu1902 the backend review is still going on, posting the test to next week

CC: @rithviknishad @Ashesh3 @sainak

rithviknishad
rithviknishad approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithviknishad rithviknishad requested a review from Ashesh3 January 22, 2024 16:17
@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Jan 22, 2024
@Pranshu1902
Copy link
Contributor Author

@nihal467 @khavinshankar the backend PR has been merged, this PR is good to merge

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2a7c261 into ohcnetwork:develop Feb 12, 2024
35 of 36 checks passed
@github-actions GitHub Actions
Copy link

@Pranshu1902 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show "Asset Down" in asset list if asset's last uptime status is down
5 participants
@Pranshu1902 @rithviknishad @Ashesh3 @nihal467 @khavinshankar